Uploaded image for project: 'TF Bugs'
  1. TF Bugs
  2. TFB-1449

Add basic git-review setup/usage to Contributors

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: In Progress
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Documentation
    • Labels:

      Description

      Here are notes I took while setting up git-review and sending my first patch (for TFB-1412). They need to be cleaned up, converted to .rst, and added to the Contributors directory.

      ------

      • Confirm you have a Jira ticket for the work (required for commit)
      • Confirm you have a signed CLA?
      • Clone the repo (if you don’t have it yet)
        • Log into gerrit.tungsten.io
        • Click Browse > Repositories
        • Select the repo you want
        • git clone "ssh://vmbrasseur@gerrit.tungsten.io:29418/docs"
      • Set up SSH access for Gerrit (required for the scp in the next step)
        • Log into gerrit.tungsten.io (if you’re not already)
        • Click the ‘Settings’ gear in the upper right next to your name
        • Click ‘SSH Keys’
        • Add your *public* SSH key (.pub)
        • Test: ssh -p 29418 vmbrasseur@gerrit.tungsten.io gerrit version
        • Should be `gerrit version 2.16.8` or higher
      • Make necessary changes
      • Commit your  changes
        • Use `commit -s` so you’ll get the signed-off-by, which is required by git review
        • If you forget to sign a commit, run `git commit --amend -s -c <SHA>` on it
      • Run `git review` to get the patch into Gerrit
        • git review

       

      Success looks something like this:

      Θυια:docs vmb$ git review

      remote:

      remote: Processing changes: }}{{new: 1 ()

      remote: Processing changes: new: 1 (|)

      remote: Processing changes: new: 1

      remote: Processing changes: new: 1

      remote: Processing changes: new: 1 ()

      remote: Processing changes: refs: 1, new: 1 ()

      remote: Processing changes: refs: 1, new: 1, done

      remote:

      remote: SUCCESS

      remote:

      remote: New Changes:

      remote:   https://gerrit.tungsten.io/r/c/docs/+/24 Reorg docs directories

      To ssh://gerrit.tungsten.io:29418/docs 

      * [new branch]      HEAD -> refs/for/master

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            vmbrasseur VM Brasseur
            Reporter:
            vmbrasseur VM Brasseur
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: